Skip to content

Typecheck cursor.py #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Typecheck cursor.py #2550

wants to merge 3 commits into from
+161 −85

Conversation

@sfc-gh-bchinn
Copy link
Contributor

@sfc-gh-bchinn sfc-gh-bchinn commented Sep 23, 2025 •
edited
Loading

Run mypy on cursor.py and fix issues.

All asserts added in this PR are safe; if the condition was violated, it would've been an AttributeError in a subsequent line anyway.

@sfc-gh-bchinn sfc-gh-bchinn mentioned this pull request Sep 23, 2025
Merged
@sfc-gh-bchinn Graphite App
Copy link
Contributor Author

sfc-gh-bchinn commented Sep 23, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-bchinn sfc-gh-bchinn mentioned this pull request Sep 23, 2025
Merged
@sfc-gh-bchinn sfc-gh-bchinn marked this pull request as ready for review September 23, 2025 17:45
@sfc-gh-bchinn sfc-gh-bchinn requested a review from a team as a code owner September 23, 2025 17:45
@sfc-gh-bchinn sfc-gh-bchinn force-pushed the bchinn-SNOW-2333702-conn-cursor branch 2 times, most recently from ac6f96b to 6394dbb Compare September 23, 2025 22:33
@sfc-gh-bchinn sfc-gh-bchinn changed the title Refactoring for better types Typecheck cursor.py Sep 23, 2025
@sfc-gh-bchinn sfc-gh-bchinn force-pushed the bchinn-SNOW-2333702-conn-cursor branch from 6394dbb to 34d9d94 Compare September 23, 2025 22:41
@sfc-gh-bchinn sfc-gh-bchinn force-pushed the bchinn-SNOW-2333702-conn-cursor branch from 34d9d94 to 000d9bb Compare September 23, 2025 23:01
@sfc-gh-bchinn sfc-gh-bchinn force-pushed the bchinn-mypy-cursor branch 2 times, most recently from 8d2fa7b to 44895d0 Compare September 26, 2025 00:15
Base automatically changed from bchinn-SNOW-2333702-conn-cursor to main September 29, 2025 11:21
@sfc-gh-bchinn sfc-gh-bchinn added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 30, 2025 — with Graphite App
@sfc-gh-turbaszek
Copy link
Contributor

@sfc-gh-bchinn can we please wait with this change before we merge async io support from dev/aio-connector? We are close to complete the work and we want to avoid non crucial linting on main

@sfc-gh-bchinn
Copy link
Contributor Author

@sfc-gh-turbaszek Sure thing! I'll remove this from the port PR then

@sfc-gh-bchinn
Copy link
Contributor Author

@sfc-gh-turbaszek I broke out one of the commits into a separate PR, since we're holding off on this bigger change. Can you take a look at that? #2603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-bchinn @sfc-gh-turbaszek